[izpack-devel] remarks and patch for InstallationGroupPanel

[Elmar Grom]

Hi Stefan,

one comment I would like to add:

> 3. Pack selection: For me, automatically selecting all packs in the
choosen installation group was
> not suitable. Therefore I added the variable
"InstallationGroupPanel.doNotSelectPacks". If this
> variable has the value "yes" then the available packs are not
automatically selected when leaving
> the panel.

I feel it would be a little more logical to reverse the logic by renaming
the variable to

"InstallationGroupPanel.selectPacks"

The default may still be 'yes'

	Elmar

-----Original Message-----
From: izpack-devel-bounces at lists.berlios.de
[mailto:izpack-devel-bounces at lists.berlios.de]On Behalf Of Stefan
Wachter
Sent: Wednesday, November 22, 2006 10:16 AM
To: izpack-devel at lists.berlios.de
Subject: [izpack-devel] remarks and patch for InstallationGroupPanel


Hi all,

I added the great InstallationGroupPanel to my setup and had to do some
adjustments that might be of
general interest:

1. Missing resource: My installer has useHeadingPanel="yes". In order to use
the heading layout a
resource named "InstallationGroupPanel.headline" is required. This resource
should be defined in the
distribution. I propose "installation type" for its value.

2. Minor bug: Calculating the available packs the InstallationGroupPanel
does not consider the OS
constraints of the packs.

3. Pack selection: For me, automatically selecting all packs in the choosen
installation group was
not suitable. Therefore I added the variable
"InstallationGroupPanel.doNotSelectPacks". If this
variable has the value "yes" then the available packs are not automatically
selected when leaving
the panel.

4. I18N: I had to I18N the panel. I know that currently there is some
general work on this issue in
progress. Yet, I needed it now, and did some improvements based on the
suggestions posted at
http://thread.gmane.org/gmane.comp.java.izpack.devel/2080/focus=2080.

Cheers,
--Stefan