[izpack-devel] Fwd: Patch-Again: Sortable InstallGroups

[Markus Schlegel]

Additionally attached the documentation changes.

Markus

---------- Forwarded message ----------
From: Markus Schlegel
Date: 16.07.2007 11:56
Subject: Patch-Again: Sortable InstallGroups
To: izpack-devel <izpack-devel at lists.berlios.de>

Hi

I am sending this patch once again, and I hope someone has time to include
it into the 3.10 Branch.
The patch allows InstallGroups to be sorted inside the InstallGroupPanel
with a sortkey.

Markus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.berlios.de/pipermail/izpack-devel/attachments/20070716/7eedf721/attachment.html 
-------------- next part --------------
Index: C:/deron/3rdParty/IzPack_3.10/src/lib/com/izforge/izpack/panels/InstallationGroupPanel.java
===================================================================
--- C:/deron/3rdParty/IzPack_3.10/src/lib/com/izforge/izpack/panels/InstallationGroupPanel.java	(revision 1864)
+++ C:/deron/3rdParty/IzPack_3.10/src/lib/com/izforge/izpack/panels/InstallationGroupPanel.java	(working copy)
@@ -361,7 +361,8 @@
                 if (data == null)
                 {
                     String description = getGroupDescription(group);
-                    data = new GroupData(group, description);
+                    String sortKey = getGroupSortKey(group);
+                    data = new GroupData(group, description, sortKey);
                     installGroups.put(group, data);
                 }
             }
@@ -434,7 +435,32 @@
 
         return description;
     }
+    
+    /**
+     * Look for a key = InstallationGroupPanel.sortKey.[group] entry:
+     * by using idata.getVariable(key)
+     * if this variable is not defined, defaults to group
+     * @param group - the installation group name
+     * @return the group sortkey
+     */
+    protected String getGroupSortKey(String group)
+    {
+        String key = "InstallationGroupPanel.sortKey." + group;
+        String sortKey = idata.getVariable(key);
+        if (sortKey == null)
+            sortKey = group;
+        try
+        {
+            sortKey = URLDecoder.decode(sortKey, "UTF-8");
+        }
+        catch (UnsupportedEncodingException e)
+        {
+            emitWarning("Failed to convert sortKey", e.getMessage());
+        }
 
+        return sortKey;
+    }
+
     protected TableModel getModel(HashMap groupData)
     {
         String c1 = parent.langpack.getString("InstallationGroupPanel.colNameSelected");
@@ -460,12 +486,12 @@
                GroupData g1 = (GroupData) o1;
                GroupData g2 = (GroupData) o2;
 
-               if (g1.name == null || g2.name==null)
+               if (g1.sortKey == null || g2.sortKey==null)
                {
                    return 0;
                }
 
-               return g1.name.compareTo(g2.name);
+               return g1.sortKey.compareTo(g2.sortKey);
            }
         });
 
@@ -521,13 +547,15 @@
 
         String name;
         String description;
+        String sortKey;
         long size;
         HashSet packNames = new HashSet();
 
-        GroupData(String name, String description)
+        GroupData(String name, String description, String sortKey)
         {
             this.name = name;
             this.description = description;
+            this.sortKey = sortKey;
         }
 
         String getSizeString()
@@ -557,6 +585,8 @@
             tmp.append(name);
             tmp.append("){description=");
             tmp.append(description);
+            tmp.append(", sortKey=");
+            tmp.append(sortKey);
             tmp.append(", size=");
             tmp.append(size);
             tmp.append(", sizeString=");
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_installGroup_documentation.txt
Url: https://lists.berlios.de/pipermail/izpack-devel/attachments/20070716/7eedf721/attachment.txt