[izpack-devel] JRE 1.6 and HTMLInfoPane

Bartz, Klaus Klaus.Bartz at coi.de
Tue May 22 10:20:40 CEST 2007


Hi Steffen,
with the minimal installation I can reproduce the problem.
If there are more panels the problem occurs not or rarely.
I do not really know why this will be happen, but I have found
where the problem can be fixed. I have just checked in it into
trunk and 3.10. If you will change it in your source, the diff
for 3.10 is:

Modified: izpack-src/branches/3.10/src/lib/com/izforge/izpack/gui/IzPanelLayout.java
===================================================================
--- izpack-src/branches/3.10/src/lib/com/izforge/izpack/gui/IzPanelLayout.java	2007-05-22 07:58:09 UTC (rev 1840)
+++ izpack-src/branches/3.10/src/lib/com/izforge/izpack/gui/IzPanelLayout.java	2007-05-22 08:14:58 UTC (rev 1841)
@@ -826,6 +826,12 @@
                         int curPixel = (int) ((colConstraints[i].getXStretch() / rowStretch) * pixel);
 
                         Rectangle curBounds = colConstraints[i].component.getBounds();
+                        // The width of some components differ from time to time. E.g. a JScrollPane
+                        // with a JEditorPane as viewport has sometimes the minimum column width and
+                        // some times the width of the scroll bar. Therefore we use the minimum
+                        // column width.
+                        int curWidth = this.minimumColumnWidth(i);
+                        if (curBounds.width < curWidth) curBounds.width 
+ = curWidth;
                         int newWidth = curPixel + curBounds.width;
                         colConstraints[i].component.setBounds(curBounds.x + offset, curBounds.y,
                                 newWidth, curBounds.height);

Cheers

Klaus

> -----Original Message-----
> From: izpack-devel-bounces at lists.berlios.de 
> [mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of 
> Dr. Steffen Greiffenberg
> Sent: Monday, May 21, 2007 10:03 AM
> To: izpack-devel at lists.berlios.de
> Subject: Re: [izpack-devel] JRE 1.6 and HTMLInfoPane
> 
> 
> Hi Klaus,
> 
> I've created some screenshots under linux, windows and mac os 
> x. They  
> all show the border-bug. The installer was created under windows  
> using 1.6.0_01-b06. You can download the screenshots, the created  
> installer and its sources under:
> 
>    http://www.semture.de/images/stories/izpack-bug.zip
> 
> 
> Kind regards
> Steffen
> 
> 
> Am 21.05.2007 um 09:47 schrieb Bartz, Klaus:
> 
> > i Steffen,
> > I think the best will be to look into your installation on
> > my box. 600k are a little bit much for an email list where
> > it is possible that some user do not use DSL. Therefore
> > you can try to send me the jar and a zip file with the 
> sources to my 
> > BerliOS account (you have to login todo it) or send me via this way 
> > your email address to communicate ante portas.
> >
> > Cheers
> >
> > Klaus
> >
> >
> >> -----Original Message-----
> >> From: izpack-devel-bounces at lists.berlios.de
> >> [mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of Dr. 
> >> Steffen Greiffenberg
> >> Sent: Wednesday, May 16, 2007 5:16 PM
> >> To: izpack-devel at lists.berlios.de
> >> Subject: Re: [izpack-devel] JRE 1.6 and HTMLInfoPane
> >>
> >>
> >> Hi Klaus,
> >>
> >>> I think you mean the borders which are wider as needed.
> >>> I have just tested the IzPack installation self with a
> >> 1.6.0_01 VM. At
> >>> three tests I have seen it zero times. I assume that you 
> have build 
> >>> the installation with the 1.6 and runs the installation
> >> with the 1.6.
> >>> What if you compile with a 1.5?
> >>
> >> I've tried this (and many others :)  and it makes no 
> difference. The 
> >> borders are still there. I've minimized my "build.xml" to:
> >>
> >> --------------------------------------------------------------
> >> ----------
> >> ----------------------
> >> <?xml version="1.0" encoding="iso-8859-1" standalone="yes" ?>
> >>
> >> <installation version="1.0">
> >>
> >>      <info>
> >>          <appname>Dummy</appname>
> >>          <appversion>Dummy</appversion>
> >>          <javaversion>1.5.0</javaversion>
> >>      </info>
> >>
> >>      <guiprefs width="800" height="620" resizable="no">
> >>          <modifier key="useLabelIcons" value="no"/>
> >>      </guiprefs>
> >>
> >>      <locale>
> >>          <langpack iso3="deu"/>
> >>      </locale>
> >>
> >>      <resources>
> >>          <res id="Installer.image.0" src="installer_images/ 
> >> InstallerImage.1.Info.gif"/>
> >>          <res id="HTMLInfoPanel.info" src="readme.html"/>
> >>      </resources>
> >>
> >>      <panels>
> >>          <panel classname="HTMLInfoPanel"/>
> >>      </panels>
> >>
> >>      <packs>
> >> 	<pack id="core" name="core" required="yes">
> >>              <description/>
> >>          </pack>
> >>      </packs>
> >>
> >> </installation>
> >> --------------------------------------------------------------
> >> ----------
> >> ----------------------
> >>
> >> My readme.html now only contains "<html><body>test</body></html>". 
> >> For JDK 1.6 a screenshot is attached. By the way: Now the bug is 
> >> really reproducible for me. I can start the installation with this 
> >> example as often as I want, and only saw the wide border.
> >>
> >> I can send you the jar-file if you want it. It's only about 600kB.
> >>
> >>
> >> Kind Regards
> >> Steffen
> >>
> >>
> >>>
> >>> Cheers
> >>>
> >>> Klaus
> >>>
> >>>> -----Original Message-----
> >>>> From: izpack-devel-bounces at lists.berlios.de
> >>>> [mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of Dr. 
> >>>> Steffen Greiffenberg
> >>>> Sent: Wednesday, May 16, 2007 2:09 PM
> >>>> To: izpack-devel at lists.berlios.de
> >>>> Subject: [izpack-devel] JRE 1.6 and HTMLInfoPane
> >>>>
> >>>>
> >>>> Hi,
> >>>>
> >>>> I've noticed a bug in the HTMLInfoPane or the JRE 1.6. I
> >> don't know
> >>>> who should I blame :) I'm running the current version 
> 3.10.2 (build
> >>>> 2007.05.11) and Java 1.6.0_01-b06, mixed mode, sharing.
> >>>>
> >>>> You see a screenshot showing what happens if I run the created 
> >>>> installer under Java 1.6. Java 1.5 works fine by the way.
> >> The strange
> >>>> thing is, that if I run the installer several times, 
> there is one 
> >>>> correct behaviour under let's say 10 screens like the 
> attached. The 
> >>>> content of the HTMLInfoPane doesn't matter, I've tried a simple 
> >>>> <html><body>test</body></html> which shows the same result.
> >>>>
> >>>> I've fixed the size of the installer by:
> >>>>
> >>>>     <guiprefs width="800" height="620" resizable="no">
> >>>>          <modifier key="useLabelIcons" value="no"/>
> >>>>     </guiprefs>
> >>>>
> >>>> If the size is not fixed everything is a bit smaller but
> >> the border-
> >>>> bug is the same. Any idea what's wrong there?
> >>>>
> >>>>
> >>> _______________________________________________
> >>> izpack-devel mailing list
> >>> izpack-devel at lists.berlios.de 
> >>> https://lists.berlios.de/mailman/listinfo/izpack-devel
> >>>
> >>
> >>
> >>
> > _______________________________________________
> > izpack-devel mailing list
> > izpack-devel at lists.berlios.de 
> > https://lists.berlios.de/mailman/listinfo/izpack-devel
> >
> 
> Freundliche Grüße aus Dresden
> Steffen Greiffenberg
> 
> -- 
> semture GmbH
> Gostritzer Str. 61-63
> D-01157 Dresden
> 
> http://www.semture.de
> Tel.: +49 (351) 871 8475
> Fax:  +49 (351) 871 8476
> 
> Sitz/Registergericht: Dresden, HRB 20110
> Geschäftsführer: Dr. Steffen Greiffenberg, Prof. Dr. Werner Esswein
> 
> 
> _______________________________________________
> izpack-devel mailing list
> izpack-devel at lists.berlios.de 
> https://lists.berlios.de/mailman/listinfo/izpack-devel
> 



More information about the izpack-devel mailing list